Dear Wolfgang, Wolfgang Denk wrote: > Dear Matthias Ludwig, > > In message <20090507071155.ga8...@ultratronik.de> you wrote: >> This is not really a change. The cs configuration was correct, but not >> the naming of it. >> >> OMAP34XX_GPMC_BASE (0x6e000000) + 0x150 = base address of configuration >> registers for GPMC-CS5 not GPMC-CS6. > > Can we please get rid of all this crap with register offsets and > device accesses through pointers using base address plus offset? > > Please provide proper C structs!
Would you like to have a look to the code snippet visible in Matthias' patch http://lists.denx.de/pipermail/u-boot/2009-May/052157.html ? It's my understanding that what's in code writel(NET_GPMC_CONFIG1, &gpmc_cs5_base->config1); is what you want? I.e. as I understand it, the code is correct (we use C structs), and the style Matthias used above you complain about was just for patch explanation (to make it easier understandable). Sorry if I missed something, just correct then ;) Best regards Dirk _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot