Hi Stefan, On 21/06/2018 18:39, Stefano Babic wrote: > Hi Stefan, > > On 21/06/2018 17:22, Tom Rini wrote: >> On Thu, Jun 21, 2018 at 01:46:10PM +0200, Stefan Agner wrote: >> >>> Tom, Stefano, >>> >>> Scott Wood seems not to be very active this days in the U-Boot >>> community. >>> >>> This patchsets seem all to be blocked due to that: >>> https://patchwork.ozlabs.org/cover/897263/ >>> https://patchwork.ozlabs.org/cover/901995/ >>> https://patchwork.ozlabs.org/patch/922907/ >>> >>> Those patches have been around quite a while and I tested them well. Any >>> change to get that still in? >> >> I don't object to those coming in via one of the SoC trees, thanks! >> > > Ok - we have a general agreement, I pick your patches into u-boot-imx. >
I get several broken boards and many warnings when I build with your patches. Maybe have I missed some of them ? I have pushed a temporary branch (nand-imx) on the server, let me know if I miss something. There are 15 boards broken, errors seem trivial but I do not want to fix anything without showing to you. There are mainly two issues, for example: drivers/mtd/nand/mxs_nand_spl.c: In function ?mxs_nand_init?: drivers/mtd/nand/mxs_nand_spl.c:148:2: error: too many arguments to function ?board_nand_init? board_nand_init(&nand_chip); ^~~~~~~~~~~~~~~ In file included from drivers/mtd/nand/mxs_nand_spl.c:7:0: include/nand.h:39:6: note: declared here void board_nand_init(void); ^~~~~~~~~~~~~~~ make[4]: *** [spl/drivers/mtd/nand/mxs_nand_spl.o] Error 1 make[3]: *** [spl/drivers/mtd/nand] Error 2 make[2]: *** [spl/drivers] Error 2 make[1]: *** [spl/u-boot-spl] Error 2 make: *** [sub-make] Error 2 The second one is a missing include, like in mx28evk: drivers/mtd/nand/mxs_nand.c: In function ?mxs_nand_calc_ecc_layout_by_info?: drivers/mtd/nand/mxs_nand.c:172:7: error: ?SZ_512? undeclared (first use in this function) case SZ_512: ^~~~~~ drivers/mtd/nand/mxs_nand.c:172:7: note: each undeclared identifier is reported only once for each function it appears in drivers/mtd/nand/mxs_nand.c:175:7: error: ?SZ_1K? undeclared (first use in this function) case SZ_1K: ^~~~~ make[2]: *** [drivers/mtd/nand/mxs_nand.o] Error 1 make[1]: *** [drivers/mtd/nand] Error 2 make: *** [sub-make] Error 2 Can you take a look ? Thanks, Stefano -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot