Thanks for the feedback. Gladly if VERSION_ID is empty the code goes to the old behavior, which means there is no change to non-Ubuntu handling (which matches the spirit of SRUs to avoid changing/regressing something else).
I'd indeed not want to re-roll all of it - but happy if there is a real issue reported around it. In that case more conditions can opt into the the new path being `systemctl is-system-running --wait`. Forward it might be reasonable to make it the default, but now and for the SRU I'd want to avoid that. ** Description changed: + [ Impact ] + + * New releases no more can check for runlevel (see details + in the original report) + + * Treat plucky onward like that and use + `systemctl is-system-running --wait` there + + [ Test Plan ] + + * Compare the behavior of uvtool creating and starting guests on the + target releases we apply this SRU to. In particular use guests of + e.g. Noble (old behavior) and Plucky (new behavior). + Ensure to use the --wait option which is what we are changing here + + [ Where problems could occur ] + + * Changes are isolated to --wait, the code tries to tolerate e.g. a + missing VERSION_ID (fallback to old behavior). Due to that the wait + behavior is what to watch out for if e.g. this detection goes mad. + + [ Other Info ] + + * The upload is the same change for all releases which should make + it easier to review. + + --- original report --- + Hi, Plucky uses login(1) from util-linux instead of shadow, which means that utmp will not be updated anymore. This is what systemd's runlevel shim uses to determine the current runlevel, so from Plucky onwards running "runlevel" will return "unknown". "uvt-kvm wait"'s remote-wait-script relies on runlevel to determine whether the virtual machine is ready, and when executed against a Plucky VM the script will enter an infinite loop waiting for "runlevel" to return a valid output. The script needs to be updated to take into account systemd systems. I am locally relying on "systemctl get-default", but I'm not sure if it's enough. Debian's autopkgtest project also had to deal with this problem, and this is what they did: https://salsa.debian.org/ci-team/autopkgtest/-/commit/677af48 Maybe "systemctl is-system-running" is more trustworthy. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2095042 Title: uvt-kvm remote-wait-script doesn't work from Plucky onwards To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/uvtool/+bug/2095042/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
