(In reply to Erik Karlsson from comment #50) > Created attachment 113754 [details] [review] > drm/nv50: Fix backlight not working when PWM_DIV is uninitialised (v4) > > I redid the patch for 3.18.6. Not sure what the use of removed nvif_rd32() > chunk was, but it doesn't seem to be necessary anymore. > > Could this fix be predicated on the specific PCI ID if the effects are > uncertain?
No, the value of NV50_PDISP_SOR_PWM_DIVis not derived from the PCI ID. Judging by some other traces I've seen, we can't just unconditionally set 0x5e to NV50_PDISP_SOR_PWM_DIV. Rather, someone needs to step up and figure out how this parameter is correctly determined, which requires some RE'ing work on a laptop that actually has it's brightness controlled by the NVIDIA GPU rather than ACPI or some other backlight component. Only then a patch like this can be merged. -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xserver-xorg-video-nouveau in Ubuntu. https://bugs.launchpad.net/bugs/921321 Title: nouveau: dark screen after suspend/resume To manage notifications about this bug go to: https://bugs.launchpad.net/nouveau/+bug/921321/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
