Hi Greg, > -----Original Message----- > From: Greg Ungerer [mailto:gregunge...@westnet.com.au] > Sent: Tuesday, April 16, 2013 4:09 PM > To: Christian Gieseler > Cc: 'uClinux development list' > Subject: Re: [uClinux-dev] Initial Timer on m5329 not running > > Hi Christian, > > On 16/04/13 19:01, Christian Gieseler wrote: > >> -----Original Message----- > >> From: Greg Ungerer [mailto:gregunge...@westnet.com.au] > >> Sent: Tuesday, April 02, 2013 8:27 AM On 26/03/13 16:54, Christian > >> Gieseler wrote: > >>> diff git a/Linux3.6.11/arch/m68k/platform/coldfire/m532x.c > >>> b/Linux3.6.11/arch/m68k/platform/coldfire/m532x.c > >>> > >>> --- a/Linux3.6.11/arch/m68k/platform/coldfire/m532x.c > >>> > >>> +++ b/Linux3.6.11/arch/m68k/platform/coldfire/m532x.c > >>> > >>> @@ 120,6 +120,8 @@ static struct clk * const enable_clks[] > >>> __initconst = { > >>> > >>> &__clk_0_25, /* mcfuart.1 */ > >>> > >>> &__clk_0_26, /* mcfuart.2 */ > >>> > >>> + &__clk_0_28, /* mcftmr.0 */ > >>> > >>> + &__clk_0_29, /* mcftmr.1 */ > >> > >> Is this patch reversed? > > > > What do you mean with reversed? If I have a look at > > http://lxr.linux.no/#linux+v3.8.7/arch/m68k/platform/coldfire/m532x.c > > In that file: > > &__clk_0_25, /* mcfuart.1 */ > &__clk_0_26, /* mcfuart.2 */ > &__clk_0_28, /* mcftmr.0 */ > &__clk_0_29, /* mcftmr.1 */ > > Yet your patch above is adding those same mcftimer lines. > So I suspect you diffed the files in the wrong order when you generated the > patch (that is you did "diff <new-file> <old-file>" instead of the other way > around). > > > > they > > are disabled. > > I don't follow. Disabled?
By disabled i ment that they are liste in disable_clks[] section in the current mainline version. The Patch adds them to the enable_clks[] section. Regards Christian _______________________________________________ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
