Benjamin, The fix is good. I can't reproduce your problem but I had it a long time ago. There's an issue open for it. After the 2.5 I'll try to completly refactor the plugin and I'll use xmlUnit to compare xml files instead of using line per line checks. It's time to release !!! ;-)
Arnaud On Fri, Mar 14, 2008 at 7:45 PM, Siarhei Dudzin <[EMAIL PROTECTED]> wrote: > I don't think releasing anything with failing tests a good idea no matter > whether the problem is with the test or with the plugin. > > Siarhei > > On Fri, Mar 14, 2008 at 11:07 AM, Benjamin Bentmann < > [EMAIL PROTECTED]> wrote: > > > > > > I had to fix the project testcase #10 > > > > Indeed, we have a tricky thing here: While "file:${M2_REPO}" will expand > > to > > a proper URI on Unix, it won't on Windows which would rather need > > "file:/${M2_REPO}". > > > > I added some hackery to AbstractEclipsePluginTestCase.assertFileEquals() > > to > > fix the URI read from the expected ".classpath". Please verify the tests > > are > > passing on Unix, too. > > > > The RadPluginTest.testProject6() is still failing for me because it does > > not > > account for XML attributes being unordered. But that's no failure of the > > plugin itself and shouldn't stop the release. > > > > > > Benjamin > > -- > > View this message in context: > > > http://www.nabble.com/maven-eclipse-plugin-2.5-coming-soon-tp15207954s177p16047715.html > > Sent from the Maven - Users mailing list archive at Nabble.com. > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > -- .......................................................... Arnaud HERITIER .......................................................... OCTO Technology - aheritier AT octo DOT com www.octo.com | blog.octo.com .......................................................... ASF - aheritier AT apache DOT org www.apache.org | maven.apache.org ...........................................................