<http://www.oracle.com/cdc/>
Hi,
In learning utrace, found possible typo in latest patch.
arch/ia32/ptrace32.c, static int putreg32(struct task_struct *child,
unsigned regno, u32 val)
+ case offsetof(struct user_regs_struct32, es):
+ child->thread.es = val &= 0xffff;
+ if (child == current)
+ loadsegment(ds, val);
maybe
+ loadsegment(es, val);
In ia32_genregs_set and genregs_set (arch/x86/kernel/ptrace_64.c)
+ else {
+ int ret = 0;
+ const u32 __user *up = ubuf;
+ while (!ret && count > 0) {
I think it's redundant to declare "ret" variable since there is same variable
outside. It could cause incorrect return value in case of error.
Regards,
Wenji
