Hello Roland,

The x86-tracehook code now contains this line in syscall_get_error():

        return error >= -4095L ? error : 0;

Hard-wiring a constant is not nice. Let's use the IS_ERR_VALUE macro
from linux/err.h instead.

Signed-off-by: Petr Tesarik <[EMAIL PROTECTED]>

diff --git a/include/asm-x86/syscall.h b/include/asm-x86/syscall.h
index 6f29389..3202051 100644
--- a/include/asm-x86/syscall.h
+++ b/include/asm-x86/syscall.h
@@ -14,6 +14,7 @@
 #define _ASM_SYSCALL_H 1
 
 #include <linux/sched.h>
+#include <linux/err.h>
 
 static inline long syscall_get_nr(struct task_struct *task,
                                  struct pt_regs *regs)
@@ -47,7 +48,7 @@ static inline long syscall_get_error(struct task_struct *task,
                 */
                error = (long) (int) error;
 #endif
-       return error >= -4095L ? error : 0;
+       return IS_ERR_VALUE(error) ? error : 0;
 }
 
 static inline long syscall_get_return_value(struct task_struct *task,


Reply via email to