> > > I still think EXIT_DEAD check must die ;)
> >
> > In get_utrace_lock, you mean?  Do you mean it's superfluous because we can
> > rely on utrace_reap having cleared engine->ops before it matters to us?
> 
> Yes. Perhaps I missed something, but this check buys nothing. First of
> all this check is racy without tasklist. Bit it is also unneeded, I think.

Good enough.  Let's drop it.

> Perhaps engine->tracee still makes sense even if engine doesn't pin
> task_struct, utrace_control/barrier/set_events do not need "target"
> argument in this case. And this means it would a bit be easier to
> use them. And we can kill _pid() helpers. But this is another story.

Yes, it's another story.  I am inclined against it, but for reasons that
are a bigger discussion.


Thanks,
Roland

Reply via email to