I'm skeptical this is the desireable way to move the code around. Of course, for all such things, I am fine with whatever upstream likes. But here are my concerns:
That is not friendly to git history at all. If you move big chunks of code to different files, it's ideal to do it in a sequence of changes wherein the git file rename detection will grok what you are doing. With big cut and paste changes like this, it winds up looking like you introduced all the moved old code today. It takes manual looking and poking with git to see you moved it out of another file in this commit and then "git annotate this~1 -- kernel/ptrace.c" to find the commits that are really responsible for each line of code. I don't see how this route is any better than having the new and old code in kernel/ptrace.c with #ifdef. Conversely, just leave the common code in ptrace.c and compile it there. AFAICT the only static function that would need to be made global for that is __ptrace_detach. Thanks, Roland
