LGTM
http://codereview.chromium.org/1572004/diff/1/2 File src/runtime.cc (right): http://codereview.chromium.org/1572004/diff/1/2#newcode4481 src/runtime.cc:4481: // the 'I' character ('Infinity'). All of that have codes greater than '9' All of that have codes less than '9' http://codereview.chromium.org/1572004/diff/1/2#newcode4486 src/runtime.cc:4486: } else if (len - start_pos < 10 && AreDigits(data, start_pos, len)) { Maybe add comment (or similar): The maximal/minimal smi has 10 digits. If the string has less digits we know it will fit into the smi-data type. http://codereview.chromium.org/1572004 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
