sorry for the review delay, was travelling.
https://codereview.chromium.org/11377158/diff/11001/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/11377158/diff/11001/src/heap.cc#newcode7459 src/heap.cc:7459: if (!getter_fun->shared()->native()) continue; I don't think this can guard you well enough. Here is an idea: I steal a function that is known to be native and that has a very predictable behavior e.g. Array.prototype.pop and then I install my own getter on .length because pop is known to access it. This way I can track when pop is called (JavaScript is fun). What about using function IDs (that Crankshaft uses for optimization) to detect this case safely? You'll need to introduce %SetFunctionId thingy though or something... https://codereview.chromium.org/11377158/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
