Reviewers: Benedikt Meurer,
Message:
Committed patchset #1 manually as r19049 (tree was closed).
Description:
Revert "Dispose Isolate at end of cctest."
Things work locally, only the waterfall is unhappy for some arcane reason.
Investigating...
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=19049
Please review this at https://codereview.chromium.org/133193006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -1 lines):
M test/cctest/cctest.h
Index: test/cctest/cctest.h
diff --git a/test/cctest/cctest.h b/test/cctest/cctest.h
index
d9f76294e1a5d432db4b2fdf9127d39630a02e00..6c67dd52ec4094d7e6805266879e1d92b3f20cfb
100644
--- a/test/cctest/cctest.h
+++ b/test/cctest/cctest.h
@@ -131,7 +131,8 @@ class CcTest {
v8::Isolate* isolate = CcTest::isolate());
static void TearDown() {
- if (isolate_ != NULL) isolate_->Dispose();
+ // TODO(svenpanne) Enable this when our cctests are fixed.
+ // if (isolate_ != NULL) isolate_->Dispose();
}
private:
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
