Re: [vchkpw] disable_external_relay [PATCH]

[Devendra Singh]

Dear Tonino / Tom,

In between the whole expert discussion the user level curious question 
"BTW, where is this user's limits info stored in case of non-mysql limits?" 
got lost.

Please, let us know.

Devendra Singh

At 04/12/03 14:32 (), tonix (Antonio Nati) wrote:

Tom,

thanks for your clear explanation.

However, don't you think that kind of things should be discussed in the 
general list instead of development list?

I feel that development list should deal with "implementation", "how to 
develop", "how to improve code", while functionalities should be discussed 
with end-users (or production users), that are interested in 
functionalities, and don't care about implementation.

I'm really amazed when I discover a changed feature and see that it's been 
done by developers without talking with end-users.

Ciao,

Tonino

At 03/12/2003 03/12/2003 -0700, you wrote:
On Wednesday, December 3, 2003, at 10:05  AM, tonix (Antonio Nati) wrote:
Tom,

sorry if I may be out of logic, just a fast look at the patch.
Here's how it works.

pw_gid is the user's limits.
if the user has V_OVERRIDE set, that's all they get.
otherwise, the domain limits are IN ADDITION to the user's limits.
For example:

If domain limit says no IMAP and user limit says no SMTP; user doesn't 
have access to IMAP or SMTP.

Change domain limit from no IMAP to no POP.  Now user limit becomes no 
POP or SMTP.

We discussed this on the development list.  Perhaps we need to explain it 
better in the documentation.

Is it correct to keep using user flags if override is off?
Yes.

+    if ((! (pw->pw_gid & V_OVERRIDE))
if user not overriding domain limits

+      && (vget_limits (domain, &limits) == 0)) {
+        pw->pw_flags = pw->pw_gid | vlimits_get_flag_mask (&limits);
using mixed limits from user and domain.
Correct.

Would it be more direct to use only domain limits in such a case?
No.  If you do it that way, you can't impose additional limits on a 
single user in the domain (or, for example, add qmailadmin admin access).

+    } else pw->pw_flags = pw->pw_gid;
else use user limits.
Correct.  If V_OVERRIDE is set, or the limit lookup fails, it just uses 
the user limits.

At 03/12/2003 03/12/2003 -0700, you wrote:
Here's the patch to fix the domain limits problem.  It's in CVS now, 
and will be in the next release (which I'll make by the end of the 
week).  Hopefully the email gateways won't totally screw the file up...
[snip]

Thanks for including an entire copy of the patch in your response.
---
Outgoing mail is certified Virus Free.
Checked by AVG anti-virus system (http://www.grisoft.com).
Version: 6.0.528 / Virus Database: 324 - Release Date: 16/10/03