Nir Soffer has posted comments on this change. Change subject: gluster: Allow gluster mount with additional servers ......................................................................
Patch Set 19: (2 comments) https://gerrit.ovirt.org/#/c/40665/19/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 290: self._gluster_options = self._get_gluster_mount_options() Line 291: comma = ',' Line 292: if self._options is "" or self._gluster_options is "": Line 293: comma = "" Line 294: return self._options + comma + self._gluster_options Please replace this with the code in the next patch - you don't introduce code in patch and fix it in the next. Line 295: Line 296: def _get_gluster_mount_options(self): Line 297: if "backup-volfile-servers" in self._options: Line 298: self.log.warn("User specified mount options will be used.") Line 299: return "" Line 300: Line 301: volfileServer, volname = self._remotePath.split(":", 1) Line 302: volname = volname.strip('/') Line 303: volInfo = supervdsm.getProxy().glusterVolumeInfo(volname, > I don't see a suitable (gluster) exception in storage_exception.py. Ok Line 304: volfileServer) Line 305: servers = [brick.split(":")[0] Line 306: for brick in volInfo[volname]['bricks']] Line 307: servers.remove(volfileServer) -- To view, visit https://gerrit.ovirt.org/40665 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2478a5edc1fc9d24eb96d64a32a98a2467ce2989 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
