Francesco Romani has posted comments on this change. Change subject: supervdsm: generalize udevTrigger method ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/44767/4/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 350: with open(rule_file, "w") as rf: Line 351: self.log.debug("Creating rule %s: %r", rule_file, rule) Line 352: rf.write(rule) Line 353: Line 354: self.udevTrigger() is this wanted change? If so, can you please elaborate a bit why is it needed? I'm a bit surprised. Line 355: Line 356: @logDecorator Line 357: def rmAppropriateIommuGroup(self, iommu_group): Line 358: """ Line 377: else: Line 378: self.log.debug("Removing rule %s", rule_file) Line 379: Line 380: if not error: Line 381: self.udevTrigger() same as line 354 Line 382: Line 383: @logDecorator Line 384: def ksmTune(self, tuningParams): Line 385: ''' -- To view, visit https://gerrit.ovirt.org/44767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I761305a54c14e8ac8ef9f4204ee5cc5d55cb31b7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
