Martin Polednik has posted comments on this change. Change subject: supervdsm: generalize udevTrigger method ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/44767/4/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 283: return setSafeNetworkConfig() Line 284: Line 285: @logDecorator Line 286: def udevTrigger(self, attr_matches=(), property_matches=()): Line 287: self.__udevReloadRules(None) > Sending None works, but it is better to first fix __udevReloadRules, so we That shouldn't matter as long as the whole topic is considered. Line 288: cmd = [EXT_UDEVADM, 'trigger', '--verbose', '--action', 'change'] Line 289: Line 290: for name, value in property_matches: Line 291: cmd.append('--property-match={}={}'.format(name, value)) Line 350: with open(rule_file, "w") as rf: Line 351: self.log.debug("Creating rule %s: %r", rule_file, rule) Line 352: rf.write(rule) Line 353: Line 354: self.udevTrigger() > This looks wrong - what device are we trying to trigger here? It is wrong right now due to DM_NAME matching, general trigger should work here, not sure about specialization. Line 355: Line 356: @logDecorator Line 357: def rmAppropriateIommuGroup(self, iommu_group): Line 358: """ -- To view, visit https://gerrit.ovirt.org/44767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I761305a54c14e8ac8ef9f4204ee5cc5d55cb31b7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
