Antoni Segura Puimedon has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ......................................................................
Patch Set 3: Fails; I would prefer that you didn't submit this (1 inline comment) Discovered issue not covered by verification. .................................................... File vdsm/netconf/ifcfg.py Line 130: try: Line 131: ipaddr = nic.ip.inet.address Line 132: netmask = nic.ip.inet.netmask Line 133: gateway = nic.ip.inet.gateway Line 134: bootproto = nic.ip.inet.gateway Fail!!! THis should be bootproto. Line 135: except AttributeError: Line 136: ipaddr = netmask = gateway = bootproto = None Line 137: self.configWriter.addNic(nic.name, bonding=bonding, bridge=bridge, Line 138: mtu=nic.mtu, ipaddr=ipaddr, -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
