Giuseppe Vallarelli has posted comments on this change. Change subject: tests: WIP Adding functional tests for networking ......................................................................
Patch Set 1: (1 inline comment) .................................................... File tests/functional/networkTests.py Line 66: Line 67: def test_add_delete_a_network(self): Line 68: status, msg = vdsm_net.add_network(NETWORK_NAME) Line 69: self.assertEqual(status, SUCCESS, msg) Line 70: self.assertTrue(vdsm_net.network_exists(NETWORK_NAME)) Ehy Toni, thanks for the feedback! I plan to add more tests to this patch, so your hint can be definitely an option. Let me see how it evolves. Line 71: Line 72: status, msg = vdsm_net.del_network(NETWORK_NAME) Line 73: self.assertEqual(status, SUCCESS, msg) -- To view, visit http://gerrit.ovirt.org/14840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3be71db9dc0b92c443b87e22fe06f920055c4d3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches