Dan Kenigsberg has posted comments on this change. Change subject: tests: WIP Adding functional tests for networking ......................................................................
Patch Set 3: (1 inline comment) .................................................... File tests/functional/networkTests.py Line 87: return network_name in info.networks Line 88: Line 89: Line 90: vdsm_net = VdsmNetUtil() Line 91: create_ndummy_interfaces(1) these should not happen during import time, but during module setup time. If nose decides to skip the module, they should do nothing. Line 92: Line 93: Line 94: class NetworkTestShould(TestCaseBase): Line 95: -- To view, visit http://gerrit.ovirt.org/14840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3be71db9dc0b92c443b87e22fe06f920055c4d3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
