Mark Wu has posted comments on this change. Change subject: Improve the checking of mulitple direct users on an interface. ......................................................................
Patch Set 2: (1 inline comment) .................................................... File lib/vdsm/netinfo.py Line 600: if iface == vdict['iface']: Line 601: users.add(v) Line 602: return users Line 603: Line 604: def ifaceHasMultiUsers(self, iface): @Giuseppe, all the usages of 'not ifaceHasMultiUsers' is removed in the patch of 'netmodels for delNetwork' , are you fine to keep this name? Line 605: """ Line 606: Checks if the interface has multiple direct users. It could only happen Line 607: in the following two cases: Line 608: --> vlan1 --> network1 (bridged or bridgeless) -- To view, visit http://gerrit.ovirt.org/14872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
