Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d85dc04a2794bc0932fdf29d08442ffe50e6b8b7
https://github.com/WebKit/WebKit/commit/d85dc04a2794bc0932fdf29d08442ffe50e6b8b7
Author: Philippe Normand <[email protected]>
Date: 2026-03-30 (Mon, 30 Mar 2026)
Changed paths:
M Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp
Log Message:
-----------
REGRESSION: [GStreamer] glib/gobject/gsignal.c:2684: instance
'0x7fa458075f30' has no handler with id '2246' in
WebCore::TrackDataHolder::disconnect
https://bugs.webkit.org/show_bug.cgi?id=311071
Reviewed by Adrian Perez de Castro.
I wasn't able to reproduce this issue, but I think that the crashes were
happening due to this
sequence of events:
1. Track created, a pad (A) is associated to it
2. GObject signals connected to pad A
3. setPad() is called with pad (B)
4. disconnect is called, attempting to disconnect GObject signal handlers
associated to pad A, but
on pad B actually
Proposed solution is to clear signal handlers before setting a new pad. This is
done already for
GstStreams.
* Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
(WebCore::TrackDataHolder::setPad):
(WebCore::TrackDataHolder::setStream):
(WebCore::TrackDataHolder::disconnect):
Canonical link: https://commits.webkit.org/310226@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
