Title: [133158] trunk/Source/WebCore
- Revision
- 133158
- Author
- schen...@chromium.org
- Date
- 2012-11-01 06:54:49 -0700 (Thu, 01 Nov 2012)
Log Message
FEImage::m_document is never cleared. Why not?
https://bugs.webkit.org/show_bug.cgi?id=99243
Reviewed by Dirk Schulze.
Adding a comment to explain why the failure to clear m_document is not a problem.
No new tests because no code change at all.
* svg/graphics/filters/SVGFEImage.h:
(FEImage): Add a comment on the lifetime of m_document.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (133157 => 133158)
--- trunk/Source/WebCore/ChangeLog 2012-11-01 13:50:30 UTC (rev 133157)
+++ trunk/Source/WebCore/ChangeLog 2012-11-01 13:54:49 UTC (rev 133158)
@@ -1,3 +1,17 @@
+2012-11-01 Stephen Chenney <schen...@chromium.org>
+
+ FEImage::m_document is never cleared. Why not?
+ https://bugs.webkit.org/show_bug.cgi?id=99243
+
+ Reviewed by Dirk Schulze.
+
+ Adding a comment to explain why the failure to clear m_document is not a problem.
+
+ No new tests because no code change at all.
+
+ * svg/graphics/filters/SVGFEImage.h:
+ (FEImage): Add a comment on the lifetime of m_document.
+
2012-11-01 Eugene Klyuchnikov <eustas....@gmail.com>
Web Inspector: Timeline: make "addRecord" unambiguous
Modified: trunk/Source/WebCore/svg/graphics/filters/SVGFEImage.h (133157 => 133158)
--- trunk/Source/WebCore/svg/graphics/filters/SVGFEImage.h 2012-11-01 13:50:30 UTC (rev 133157)
+++ trunk/Source/WebCore/svg/graphics/filters/SVGFEImage.h 2012-11-01 13:54:49 UTC (rev 133158)
@@ -54,6 +54,8 @@
RenderObject* referencedRenderer() const;
RefPtr<Image> m_image;
+
+ // m_document will never be a dangling reference. See https://bugs.webkit.org/show_bug.cgi?id=99243
Document* m_document;
String m_href;
SVGPreserveAspectRatio m_preserveAspectRatio;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
