Modified: trunk/Source/WebCore/ChangeLog (142937 => 142938)
--- trunk/Source/WebCore/ChangeLog 2013-02-15 00:35:13 UTC (rev 142937)
+++ trunk/Source/WebCore/ChangeLog 2013-02-15 00:36:52 UTC (rev 142938)
@@ -1,3 +1,19 @@
+2013-02-14 Joshua Bell <jsb...@chromium.org>
+
+ [V8] IndexedDB: Remove unused creationContext paramter from idbKeyToV8Value
+ https://bugs.webkit.org/show_bug.cgi?id=109870
+
+ Reviewed by Kentaro Hara.
+
+ This parameter was left over from when the function was toV8(IDBKey). Remove it.
+
+ No new tests - just removing dead code.
+
+ * bindings/v8/IDBBindingUtilities.cpp:
+ (WebCore::idbKeyToV8Value): Remove unused parameter.
+ (WebCore::injectIDBKeyIntoScriptValue): No need for dummy handle.
+ (WebCore::idbKeyToScriptValue): No need for dummy handle.
+
2013-02-14 Kondapally Kalyan <kalyan.kondapa...@intel.com>
[WebGL][Qt] regression:r142786 Qt Build fix for Arm and Windows.
Modified: trunk/Source/WebCore/bindings/v8/IDBBindingUtilities.cpp (142937 => 142938)
--- trunk/Source/WebCore/bindings/v8/IDBBindingUtilities.cpp 2013-02-15 00:35:13 UTC (rev 142937)
+++ trunk/Source/WebCore/bindings/v8/IDBBindingUtilities.cpp 2013-02-15 00:36:52 UTC (rev 142938)
@@ -39,7 +39,7 @@
namespace WebCore {
-static v8::Handle<v8::Value> idbKeyToV8Value(IDBKey* key, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
+static v8::Handle<v8::Value> idbKeyToV8Value(IDBKey* key, v8::Isolate* isolate)
{
if (!key) {
// This should be undefined, not null.
@@ -62,7 +62,7 @@
{
v8::Local<v8::Array> array = v8::Array::New(key->array().size());
for (size_t i = 0; i < key->array().size(); ++i)
- array->Set(i, idbKeyToV8Value(key->array()[i].get(), creationContext, isolate));
+ array->Set(i, idbKeyToV8Value(key->array()[i].get(), isolate));
return array;
}
}
@@ -275,7 +275,7 @@
if (parent.IsEmpty())
return false;
- if (!set(parent, keyPathElements.last(), idbKeyToV8Value(key.get(), v8::Handle<v8::Object>(), isolate), isolate))
+ if (!set(parent, keyPathElements.last(), idbKeyToV8Value(key.get(), isolate), isolate))
return false;
return true;
@@ -301,7 +301,7 @@
{
ASSERT(v8::Context::InContext());
v8::HandleScope handleScope;
- v8::Handle<v8::Value> v8Value(idbKeyToV8Value(key.get(), v8::Handle<v8::Object>(), state->context()->GetIsolate()));
+ v8::Handle<v8::Value> v8Value(idbKeyToV8Value(key.get(), state->context()->GetIsolate()));
return ScriptValue(v8Value);
}
