Great job Christian! Ive merged the changes + renamed a few little things. It looks really good. When I have time I would like to use the helper classes in the dataview impls as well. I was also thinking of getting rid of pageable dataview and introducing enablePaging(int rowsperpage)/disablePaging() into dataview directly. What do you think?
-Igor > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > Christian Essl > Sent: Wednesday, August 31, 2005 5:37 AM > To: wicket-user@lists.sourceforge.net > Subject: [Wicket-user] PageableGridDataView > > As promissed I've tried to implement a PageableGridDataView > with OIR support and empty cell fill up. Attached is a patch. > > There are a few other new classes as well let me explain: > > By the way doing this I also implemented a > PageableOrderedRepeatingView (first I thought I'll base the > GridDataView on this one). > > Now because both the GridDataView and the > PageableOrderedRepeatingView implement IPageable I've > encapsulated the logic in a PageableSupport, which the former > two delegate to. This implementation also follows what was > discussed whith Johan. > > There is also a helper for OIR - maybe it could be used > somewhere else. > > Than there are two unit tests one for the PageableSupport and > one for the OIRHelper. (If you'd like to keep the code please > also keep the tests). > > Finally I've implemented an example in data-view-examples for > the GridDataView. > > Christian > ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
