User "Brion VIBBER" posted a comment on MediaWiki.r97701. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97701#c22942 Commit summary:
* Fixed bug causing new uploads to give "template/file changes need review" message. * Fixed bug causing the same thing to happen with new uploads (bug 31056). Works via bypassing findFile() process cache. Comment: Ok, this looks like: * code is in FlaggedRevs::autoReviewEdit() which gets called on various editing activities * for image pages, one of those times will be during initial upload * we'll probably have looked with wfFindFile during that upload process, leaving a negative or old cache entry I wonder though if we should instead be clearing that in-process cache? Is its old info left over from earlier in-process lookups and changed by an in-process upload completion? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
