Dmitry Timoshkov wrote: > "Charles Davis" <cda...@mymail.mines.edu> wrote: > >>> You forgot to remove if (1). >>> >> It goes away in patch #3. I thought I already had this discussion with >> Paul. >> >> There's a reason it's there. EMF_BITBLT contains two BitBlt() records, >> but the EMF we're comparing it to only has one. That's because one of >> them is if(0)'d out because it crashes on Wine. So, if we try to compare >> the EMF we produced to the EMF we expect, it will fail. Last I checked, >> Alexandre doesn't like it when tests fail. All tests must pass on his >> box. > > There are 2 solutions for that: > 1. use todo_wine in the test, and remove it in a patch with the fix The test will fail on Windows if I do that. > 2. add the test in the patch after a patch with the fix Very well then. I'll resend with the test reordered after the fix. >
Chip