There are still a few style issues with your patch. You have inconsistent
spacing after ifs ("if (" vs "if("), missing spaces after commas, and a few
more "}else{"s. You also create a few blocks for no reason other than to get
around the C declarations on top of block rule. Please organize these in
tune with the surrounding code. Only create a "useless" block (ie a block
without a control flow statement) if there is an #ifdef around it with other
implementations. Also please don't do things like "if (x) { do {...}
while(x); }".More importantly you seem to be missing the tests for this. (sorry for top posting; mobile gmail doesn't seem to have the ability to bottom post) Mike. On Oct 6, 2010 2:16 AM, "Rudolf Mayerhofer" <r...@eightyfive.net> wrote: > Try 2: > - Exchange Patches #2 and #3. > - Fix errors in formatting > - Check that fopen succeeds, return default value otherwise > - default return value is now 0 for all parser functions > > Try 3: > - Add missing checks for valid processor mask and cache values > > Try 4: > - More comments in the parsing code > - Some additional code cleanup > > --- > dlls/ntdll/nt.c | 343 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 343 insertions(+), 0 deletions(-) >
