comma is preferred as separator in provider-name. pipe appeared to be a bit
fugly
regards,
Martijn Kaijser
Team XBMC
On Fri, Feb 14, 2014 at 12:22 AM, Tristan Fischer <
sph...@xboxmediacenter.com> wrote:
> Hi,
>
> beenje forwarded me your fixed pull request so I will take care of it.
>
> *addon - plugin.video.espn_3
> *version - 1.0.0
> *url - git://github.com/asojka09/plugin.video.espn_3.git
> *revision - 634fd148db590c1d76fd1333c5309d70ea700e0e
> *branch - Master
> *xbmc version - Frodo,Gotham
>
> I still see some issues with it:
> - default.py contains a mixture of tabs and spaces, this could cause some
> issues. (There are some other files with same mixture (settings.xml,
> addon.xml) but on xml its just cosmetics...)
> - provider-name in addon.xml is "Ksosez,BlueCop,locomot1f". Pipe should be
> preferred as seperator. Also, are you sure on that? Seems like you are the
> provider for this version.
> - There are some untranslated visible strings in use (Live, Upcoming,
> Replay, Replay All, Select a quality Level, (All), ...)
> - static media (live.png, replay.png, upcoming.png) should be placed in
> resources/media/ dir
> - using "xbmc.log(tree.prettify())" spams xbmc's log file. If you really
> need so much debug logging in users xbmc.log you should at least log it
> only when debug is enabled ("using xbmc.log(tree.prettify(),
> level=xbmc.LOGDEBUG)") - or just remove it.
> - You have some unneded imports (calender, string, htmllib, platform)
>
> Sorry to bother you again,
> I promise only the initial pull will be so hard ;)
>
> regards,
> sphere
>
> 2014-02-12 23:19 GMT+01:00 Benjamin Bertrand <bee...@xboxmediacenter.com>:
>
> There is already a plugin.video.espn.video addon.
>> It doesn't give access to ESPN3 channel?
>> If not, isn't it possible to merge those 2 addons?
>>
>> Otherwise, concerning the code review:
>> You need to add a xml header with proper encoding to
>> plugin.video.espn_3/resources/language/English/strings.xml
>>
>> Cheers
>>
>> On Wed, Feb 12, 2014 at 10:47 PM, Austin's PC Repair
>> <austinso...@hotmail.com> wrote:
>> > *addon - plugin.video.espn_3
>> > *version - 1.0.0
>> > *url - git://github.com/asojka09/plugin.video.espn_3.git
>> > *revision - a501a3b54e235f0a0c53eb313dc6a62d8beeaff2
>> > *branch - Master
>> > *xbmc version - Frodo,Gotham
>> >
>> >
>> ------------------------------------------------------------------------------
>> > Android apps run on BlackBerry 10
>> > Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
>> > Now with support for Jelly Bean, Bluetooth, Mapview and more.
>> > Get your Android app in front of a whole new audience. Start now.
>> >
>> http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
>> > _______________________________________________
>> > Xbmc-addons mailing list
>> > Xbmc-addons@lists.sourceforge.net
>> > https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>> >
>>
>>
>> ------------------------------------------------------------------------------
>> Android apps run on BlackBerry 10
>> Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
>> Now with support for Jelly Bean, Bluetooth, Mapview and more.
>> Get your Android app in front of a whole new audience. Start now.
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
>> _______________________________________________
>> Xbmc-addons mailing list
>> Xbmc-addons@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>>
>
>
>
> ------------------------------------------------------------------------------
> Android apps run on BlackBerry 10
> Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
> Now with support for Jelly Bean, Bluetooth, Mapview and more.
> Get your Android app in front of a whole new audience. Start now.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
> _______________________________________________
> Xbmc-addons mailing list
> Xbmc-addons@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>
>
------------------------------------------------------------------------------
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience. Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
_______________________________________________
Xbmc-addons mailing list
Xbmc-addons@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
