On 23-08-15 12:14, reazor...@web.de wrote:
> *addon - skin.avalon
> *version - 2.4.0
> *url - https://copy.com/SHtJlODhaQjrUUi2/skin.avalon-2.4.0.zip
> *xbmc version - isengard
>
> Now I get it. It was an adjustment at the mail provider. Sorry.
>
> Cheers and greetz
> reazorFX
great! i'm always exited when new skins are being submitted to our repo :-)
as with all skins that went in before this one, it's going to take some
effort to get it into proper shape.
this might be quite a bit of work, but when the initial issues are
fixed, subsequent skin updates should go easy as a breeze.
i had a look at Avalon and did my usual round of checking and testing.
i've come up with this list that requires your attention:
the files start with a BOM character, please remove it
./1080i/DialogContextMenu.xml
./1080i/MusicOSD.xml
./1080i/Startup.xml
./1080i/DialogProgress.xml
./1080i/Custom_Overlay.xml
./1080i/DialogSeekbar.xml
add a <?xml version="1.0" encoding="UTF-8"?> header to all your xml files
save these files in utf-8 encoding
./1080i/IncludesVariables.xml
./1080i/Settings.xml
fix the non-utf-8 characters in IncludesVariables.xml
<value condition="VideoPlayer.Content(Movies) +
player.chaptercount">$LOCALIZE[21396]
$INFO[player.chapter]$INFO[player.chaptercount, / ]
$INFO[VideoPlayer.Genre]</value>
<value
condition="VideoPlayer.Content(Episodes)">$INFO[VideoPlayer.TVShowTitle]
$LOCALIZE[20373] $INFO[VideoPlayer.Season]</value>
<value>[COLOR red][/COLOR] $LOCALIZE[1223] [COLOR
mainblue][/COLOR] $LOCALIZE[305]</value>
use Unix style eols (LF) in these files
1080i/IncludesOSD.xml: Windows (CRLF)
1080i/IncludesViews.xml: Windows (CRLF)
1080i/View_502_Showcase_Panel.xml: Windows (CRLF)
1080i/View_503_Poster.xml: Windows (CRLF)
1080i/View_504_Wall.xml: Windows (CRLF)
1080i/View_505_Wall.xml: Windows (CRLF)
1080i/View_52_Showcase_Panel.xml: Windows (CRLF)
1080i/View_53_Poster.xml: Windows (CRLF)
1080i/View_54_Wall.xml: Windows (CRLF)
1080i/View_55_Wall.xml: Windows (CRLF)
changelog.txt: Windows (CRLF)
fonts/OFL.txt: Windows (CRLF)
language/* (CRLF)
change all occurances of <onclick>-</onclick> to <onclick>noop</onclick>
the same applies to onleft/right/up/down
Undefined Includes:
DialogPVRChannelManager.xml: DialogButtonBig
DialogPVRChannelManager.xml: DialogButtonSmall (4x)
Unmatched parenthesis:
IncludesOSD.xml: [VideoPlayer.HasMenu +
!SubString(skin.string(osd_video_disc),disable)] +
!VideoPlayer.Content(LiveTV)] | Skin.HasSetting(CustomOSD)
IncludesOSD.xml: VideoPlayer.Content(episodes)] +
!IsEmpty(VideoPlayer.Studio)
IncludesVariables.xml: [Container.Content(albums) |
Container.Content(songs)] + [!IsEmpty(ListItem.Year]
IncludesVariables.xml: [Container.Content(albums) |
Container.Content(songs)] + [!IsEmpty(ListItem.Genre]
please change this to Kodi
LoginScreen.xml: <label>for XBMC</label>
remove this line from addon.xml, it's not used anymore by Kodi
defaultthemename="textures.xbt"
add a language property to these tags in your addon.xml
<summary lang="en">
<description lang="en">
add a LICENSE.txt file to your skin
rename these files
DialogSeekbar.xml > DialogSeekBar.xml
colors/Defaults.xml > colors/defaults.xml
remove the unicode="true" property from the fonset tag in Fonts.xml,
it's not used anymore by Kodi
remove the .zip files from the fonts directory
fix the comments at the top of your english language file, like this:
# Kodi Media Center language file
# Addon Name: Avalon
# Addon id: skin.avalon
# Addon Provider: reazorFX
language/english/strings.po
string id's 40001 / 40002 / 40003 are not valid for skin use, they need
to be in the 31xxx range
also, change all references to XBMC/xbmc.org in your strings to Kodi/kodi.tv
MyPVR.xml isn't used anymore, for needed changes for PVR skin support
see: http://kodi.wiki/view/Skin_migration_PVR_section_for_Helix_release
MusicVisualisation.xml
you can't hide the music info. please use the Player.ShowInfo visible
condition
MusixOSD.xml
please create a proper music osd. not one that autocloses instantly.
Font.xml
incorrect filename at line 17
Includes.xml
<include file="Custom_Home.xml" />
you can't include windows, please remove that line.
IncludesVariables.xml
<value condition="Container.Content(albums)"></value>
you can't use empty values
if anything is unclear, or if you need help, just let me know!
cheers,
ronie
------------------------------------------------------------------------------
_______________________________________________
Xbmc-addons mailing list
Xbmc-addons@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
