Hi Luca, On 11/10/2021 09:03, Luca Fancellu wrote:
+static bool __init is_boot_module(int dt_module_offset) +{ + if ( (fdt_node_check_compatible(fdt, dt_module_offset, + "multiboot,kernel") == 0) || + (fdt_node_check_compatible(fdt, dt_module_offset, + "multiboot,ramdisk") == 0) || + (fdt_node_check_compatible(fdt, dt_module_offset, + "multiboot,device-tree") == 0) ) + return true;
A boot module *must* have the compatible "multiboot,module". I would prefer if we simply check that "multiboot,module" is present.
This will also make easier to add new boot module in the future.
+ + return false; +} +
Cheers, -- Julien Grall