On 27/03/2019 17:24, Dario Faggioli wrote: > On Mon, 2019-03-18 at 14:11 +0100, Juergen Gross wrote: >> cpu_disable_scheduler() is being called from __cpu_disable() today. >> There is no need to call it on the cpu just being disabled, so use >> the CPU_DEAD case of the cpu notifier chain. >> > So, what do you mean with "There is no need to call it on the cpu just > being disabled"? > > Because we still (even after this patch, I mean) call > cpu_disable_scheduler() on all non-boot CPUs, aren't we? It's just that > right now we call it from __cpu_disable(), with the patch we call it > slightly later.
The CPU_DEAD notifier chain is called on the CPU requesting the other one to go down (so on the boot CPU in suspend case). So we call it _for_ all non-boot CPUs in the boot CPU. > And another difference looks to me to be that right now we call > cpu_disable_scheduler() from stop-machine context, which I think is no > longer true with this patch. Perhaps the changelog could tell why that > is ok? Okay, I'll add something. Juergen _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
