On Mon, Feb 03, 2020 at 03:32:01PM +0100, Roger Pau Monné wrote:
[...]
> >
> > #else
> >
> > @@ -46,6 +51,7 @@ static inline const char *hypervisor_probe(void) { return
> > NULL; }
> > static inline void hypervisor_setup(void) { ASSERT_UNREACHABLE(); }
> > static inline int hypervisor_ap_setup(void) { ASSERT_UNREACHABLE(); return
> > 0; }
> > static inline void hypervisor_resume(void) { ASSERT_UNREACHABLE(); }
> > +static inline void hypervisor_e820_fixup(struct e820map *e820) {
> > ASSERT_UNREACHABLE(); }
>
> Are you sure the assert here is fine?
>
> Consider Xen running nested on another hypervisor, and built without
> CONFIG_GUEST enabled, I think the above assert would trigger.
Hmm... yes, this assertion should be dropped. Thanks.
Wei.
>
> Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
