On 12/20/2012 08:23 AM, Tom Zanussi wrote: > On Wed, 2012-12-19 at 16:40 -0800, Darren Hart wrote: >> >> On 12/17/2012 09:51 AM, tom.zanu...@intel.com wrote: >>> From: Tom Zanussi <tom.zanu...@intel.com> >>> >>> Add a 'layer' target containing all the data that will be used to >>> generate a generic yocto layer. >>> >>> Signed-off-by: Tom Zanussi <tom.zanu...@intel.com> >>> --- >> >> Great stuff Tom, only one nit below: >> >>> new file mode 100644 >>> index 0000000..90ce90e >>> --- /dev/null >>> +++ "b/scripts/lib/bsp/substrate/target/arch/layer/{{ if >>> create_example_recipe == \"y\": }} >>> recipes-example/example/{{=example_recipe_name}}-0.1/helloworld.c" >>> @@ -0,0 +1,6 @@ >>> +#include <stdio.h> >>> + >>> +int main(int argc, char **argv) >>> +{ >>> + printf("Hello World!\n"); >> >> If you specify a return type of int, you should be returning one: >> >> return 0; >> >> :-) >> > > Hmm, I don't think that's actually necessary for main() - if you don't > specify a return value for main(), it should already implicitly return 0 > IIRC...
Possibly, but explicit is better IMO. I've been yelled at in certain forums for using the implicit return. -- Darren Hart Intel Open Source Technology Center Yocto Project - Technical Lead - Linux Kernel _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto