On Thu, Jul 21, 2016 at 5:22 AM, Bruce Ashfield <bruce.ashfi...@windriver.com> wrote: > On 2016-07-20 4:19 PM, Jacob Kroon wrote: >> >> Hi, >> I'm trying to get the SDK to be able to run the kernel's "make >> menuconfig" target >> using nativesdk-ncurses from the SDK. Looking at >> >> >> http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-4.4/commit/scripts/kconfig/lxdialog/check-lxdialog.sh?h=standard/beaglebone&id=badf6fedf455958fe0ff3c060c8e3965ef6d80dc >> >> I figured out I could pass CROSS_CURSES_[INC,LIB], but the second chunk >> in that patch looks weird: >> >> elif pkg-config --cflags ncurses 2>/dev/null; then >> echo '-DCURSES_LOC="<ncurses.h>"' >> + if [ x"$CROSS_CURSES_INC" != x ]; then >> + echo "$CROSS_CURSES_INC" >> + exit >> + fi >> elif [ -f /usr/include/ncursesw/curses.h ]; then >> echo '-I/usr/include/ncursesw -DCURSES_LOC="<curses.h>"' >> >> (I had to do manual indentation with spaces in gmail) >> Is the indentation or the logic incorrect ? > > > In the commit itself, the indentation is fine. > > That block of code is just dumping flags that are used in the > build. So in this case, it is correct. If the variable is > non empty, it is echoed and then processing exits.
The check if CROSS_CURSES_INC is non-empty is only done if the preceeding "elif"-check is true, and not unconditionally as one would expect judging by the indentation. -- _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto