Hi Paul,
Thanks for the review, I've fixed all your comments except the following ones.
On 06/21/2017 10:21 PM, Paul Eggleton wrote:
Hi Robert,
Thanks for solving this long-standing bug! Just a few notes below.
On Tuesday, 13 June 2017 4:36:47 AM CEST Robert Yang wrote:
--- a/layerindex/update_layer.py
+++ b/layerindex/update_layer.py
...
+def get_layer_var(config_data, var):
+ collection = config_data.getVar('BBFILE_COLLECTIONS', True)
This makes the assumption that the layer.conf only adds one collection
to BBFILE_COLLECTIONS. Probably a valid assumption 99.9% of the time these
days, but it is worth noting.
Should we check all BBFILE_COLLECTIONS, please ?
+ if collection:
+ collection = collection.strip()
+ value = config_data.getVar('%s_%s' % (var, collection), True)
+ if not value:
+ value = config_data.getVar(var, True)
+ return value or ''
+
...
+def explode_dep_versions2(bitbakepath, deps):
+ bblib = bitbakepath + '/lib'
+ if not bblib in sys.path:
+ sys.path.insert(0, bblib)
+ import bb.utils
+ return bb.utils.explode_dep_versions2(deps)
I'm not particularly happy with this (the wrapper nor calling bitbake code
update.py needs explode_dep_versions2 to get dependencies and then calculate
them, I had tried to move the code into update_layer.py, and let
update_layer.py print explode_dep_versions2() to update.py, but it is a
OderedDic, and not easy to process it manually, so I leave the code in
update.py.
I will send a V5 after we've made agreements.
// Robert
from update.py) but I suppose it's marginally better than duplicating
explode_dep_versions2().
Cheers,
Paul
--
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
