panbingkun commented on code in PR #46450:
URL: https://github.com/apache/spark/pull/46450#discussion_r1593871899


##########
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/SessionManager.java:
##########
@@ -84,13 +87,15 @@ public synchronized void init(HiveConf hiveConf) {
 
   private void createBackgroundOperationPool() {
     int poolSize = 
hiveConf.getIntVar(ConfVars.HIVE_SERVER2_ASYNC_EXEC_THREADS);
-    LOG.info("HiveServer2: Background operation thread pool size: " + 
poolSize);
+    LOG.info("HiveServer2: Background operation thread pool size: {}",
+      MDC.of(LogKeys.THREAD_POOL_SIZE$.MODULE$, poolSize));
     int poolQueueSize = 
hiveConf.getIntVar(ConfVars.HIVE_SERVER2_ASYNC_EXEC_WAIT_QUEUE_SIZE);
-    LOG.info("HiveServer2: Background operation thread wait queue size: " + 
poolQueueSize);
+    LOG.info("HiveServer2: Background operation thread wait queue size: {}",
+      MDC.of(LogKeys.THREAD_WAIT_QUEUE_SIZE$.MODULE$, poolQueueSize));
     long keepAliveTime = HiveConf.getTimeVar(
         hiveConf, ConfVars.HIVE_SERVER2_ASYNC_EXEC_KEEPALIVE_TIME, 
TimeUnit.SECONDS);
-    LOG.info(
-        "HiveServer2: Background operation thread keepalive time: " + 
keepAliveTime + " seconds");
+    LOG.info("HiveServer2: Background operation thread keepalive time: {} ms",
+      MDC.of(LogKeys.THREAD_KEEP_ALIVE_TIME$.MODULE$, keepAliveTime * 1000));

Review Comment:
   Let's turn our `time unit` into `ms`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to