panbingkun commented on code in PR #46450: URL: https://github.com/apache/spark/pull/46450#discussion_r1593883576
########## sql/hive-thriftserver/src/main/java/org/apache/hive/service/ServiceUtils.java: ########## @@ -18,7 +18,7 @@ import java.io.IOException; -import org.slf4j.Logger; +import org.apache.spark.internal.Logger; Review Comment: The following code use it I searched the `spark code base`. It seems that the `public static void cleanup(Logger log, java.io.Closeable... closeables)` method is not used. Maybe we can delete the following code? https://github.com/apache/spark/blob/d7f69e7003a3c7e7ad22a39e6aaacd183d26d326/sql/hive-thriftserver/src/main/java/org/apache/hive/service/ServiceUtils.java#L55-L67 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
