cloud-fan commented on code in PR #46596: URL: https://github.com/apache/spark/pull/46596#discussion_r1601726901
########## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Cast.java: ########## @@ -29,14 +29,31 @@ @Evolving public class Cast extends ExpressionWithToString { private Expression expression; + + /** + * Original data type of given expression + */ + private DataType expressionDataType; + + /** + * Target data type, i.e. data type in which expression will be cast + */ private DataType dataType; + @Deprecated Review Comment: let's explicitly set `expressionDataType` to null in this constructor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org