cloud-fan commented on code in PR #46596:
URL: https://github.com/apache/spark/pull/46596#discussion_r1601730764
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java:
##########
@@ -231,10 +231,15 @@ protected String visitBinaryArithmetic(String name,
String l, String r) {
return l + " " + name + " " + r;
}
+ @Deprecated
protected String visitCast(String l, DataType dataType) {
Review Comment:
let's remove this method directly. This is for users to override, it's worse
if we keep it and user's override does nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
