Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]
PierreSmits commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2105623501 Hi Jacques, Thanks for fixing the typo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]
JacquesLeRoux merged PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]
sonarcloud[bot] commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2105615680 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=785) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=785=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=785=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=785=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=785=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=785) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]
JacquesLeRoux commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2105615193 Hi, About the error above where git diff did not give any information ``` error: applications/marketing/data/MarketingPortletData.xml: already exists in working directory C:\projectsASF\Git\ofbiz-framework>git diff C:\projectsASF\Git\ofbiz-framework> ``` I know now what happened. As I said > The patch does no apply in Elipse nor with git apply I actually tried with Eclipse before and did not notice that MarketingPortletData.xml was already there but not added. Now we have > C:\projectsASF\Git\ofbiz-framework>git apply 785.patch > 785.patch:70: trailing whitespace. > 785.patch:71: trailing whitespace. > description="The main portal page of the marketing application" > warning: 2 lines add whitespace errors. > You can neglect, it's OK (new lines, no trailing whitespaces) About ``` - + - + ``` Not needed. In current code 29 `` vs 7 `` But maybe simple for you, not a pb finally. More important is this Typo (N/M) `` You see that's the brittle of portals. I also remember a space at head of a portal reference not bing easy to find. Anyway tests are OK and I agree it's a good improvement. Though that could have been done with no new data in DB, isn't? I'll fix the typo and push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]
sonarcloud[bot] commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2103975317 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=785) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=785=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=785=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=785=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=785=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=785) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]
PierreSmits commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2103974953 Hi @JacquesLeRoux , I have updated the pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]
PierreSmits commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2103232314 Now that is unfortunate. I will address this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]
JacquesLeRoux commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2103005543 Hi Pierre, The patch does no apply in Elipse nor with git apply: > C:\projectsASF\Git\ofbiz-framework>git apply 785.patch > 785.patch:70: trailing whitespace. > 785.patch:71: trailing whitespace. > description="The main portal page of the marketing application" > error: applications/marketing/data/MarketingPortletData.xml: already exists in working directory > > C:\projectsASF\Git\ofbiz-framework>git diff > > C:\projectsASF\Git\ofbiz-framework> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]
sonarcloud[bot] commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2076478498 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=785) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=785=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=785=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=785=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=785=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=785) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
