Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

PierreSmits commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2105623501 Hi Jacques, Thanks for fixing the typo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

JacquesLeRoux merged PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

sonarcloud[bot] commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2105615680 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

JacquesLeRoux commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2105615193 Hi, About the error above where git diff did not give any information ``` error: applications/marketing/data/MarketingPortletData.xml: already exists in working

Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

sonarcloud[bot] commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2103975317 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

PierreSmits commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2103974953 Hi @JacquesLeRoux , I have updated the pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

PierreSmits commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2103232314 Now that is unfortunate. I will address this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

JacquesLeRoux commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2103005543 Hi Pierre, The patch does no apply in Elipse nor with git apply: > C:\projectsASF\Git\ofbiz-framework>git apply 785.patch > 785.patch:70: trailing whitespace.

Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

sonarcloud[bot] commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2076478498 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate