This all seems fine.
Do other accessbridge files still have the remnants of SCCS ? :-
That was purged from all the other JDK files when we moved to mercurial.
33 /*
34 * @(#)AccessBridgeCalls.c 1.25 05/08/22
35 */
If "yes", then I suggest to file a clean-up bug to clean up all of these
separately.
if "no", then I suggest to fix this one file here and now ..
-phil.
On 10/27/2016 07:41 AM, Pete Brunet wrote:
Thanks for noticing that Phil. Updated at
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.05/
On 10/27/16 9:20 AM, Philip Race wrote:
But it still needs to say "jdk9/jdk9" not jdk9/client or jdk9/dev.
-phil.
On 10/26/16, 9:27 PM, Anirvan Sarkar wrote:
Hi,
If you replace the hex number with 'tip' then it will always point
to the latest version.
Something like
http://hg.openjdk.java.net/jdk9/client/jdk/file/tip/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c
<http://hg.openjdk.java.net/jdk9/client/jdk/file/tip/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c>
Regards,
Anirvan Sarkar
On Thursday 27 October 2016, Pete Brunet <peter.bru...@oracle.com
<javascript:_e(%7B%7D,'cvml','peter.bru...@oracle.com');>> wrote:
On 10/26/16 10:44 PM, Philip Race wrote:
>
15 <a
href="http://hg.openjdk.java.net/jdk9/client/jdk/file/544828ab2a9b/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c";
<http://hg.openjdk.java.net/jdk9/client/jdk/file/544828ab2a9b/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c>>
That URL is definitely not authoritative.
I think you need to give a pointer to something more like
http://hg.openjdk.java.net/jdk9/jdk9/jdk/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c
<http://hg.openjdk.java.net/jdk9/jdk9/jdk/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c>
Looks like that hex number in there is the Mercurial long
revision number of the tip so that's going to keep changing.
I'm not aware of a "latest" link. Maybe some other reader will
know.
But I am not sure about that either .. it may need to be split between the
main URL and the location in the repo.
-phil
On 10/26/16, 7:24 PM, Pete Brunet wrote:
Please review the latest update at
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.03/
<http://cr.openjdk.java.net/%7Eptbrunet/JDK-8167213/webrev.03/>
The change is to AccessBridgeCalls.c. The license has been changed from
GPL2 to BSD. This is because the file was originally unlicensed prior
to being bundled into the JDK and the compiled .obj is linked to by
vendors creating proprietary code. Vendors will be instructed to
download AccessBridgeCalls.c from the OpenJDK repository. Also the
include/use of AccessBridgeDebug.h/cpp has been removed.
Please also review readme.html which has been added to
.../jdk/include/win32/bridge.
Pete
On 10/25/16 6:48 AM, Alexandr Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 10/24/2016 1:18 PM, Erik Joelsson wrote:
The last change looks good and simple to me.
/Erik
On 2016-10-21 06:55, Pete Brunet wrote:
Please see the latest update
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.02/
<http://cr.openjdk.java.net/%7Eptbrunet/JDK-8167213/webrev.02/>
The fix now is to simply remove the copy of the AccessBridgeCalls.c
file
into the JDK.
AccessBridgeCalls.c is the implementation of the documented Java Access
Bridge API and is a set of wrapper functions that hides the
complications related to interfacing to JAB's WindowsAccessBridge*.dll.
In the past users of the API would compile and link to
AccessBridgeCalls.c/obj.
Since the interface implementation of AccessBridgeCalls.c will no
longer
be provided the JAB API documentation will be updated to instruct a
user
how to create an equivalent of AccessBridgeCalls.c. The documentation
will also contain a reference to the JAB 2.0.2 download
http://www.oracle.com/technetwork/java/javase/downloads/jab-2-0-2-download-354311.html
<http://www.oracle.com/technetwork/java/javase/downloads/jab-2-0-2-download-354311.html>
which does contain AccessBridgeCalls.c and which is compatible with the
current API and related calls into WindowsAccessBridge*.dll.
Pete
On 10/18/16 12:28 PM, Pete Brunet wrote:
I've updated the webrev. Please see
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.01/
<http://cr.openjdk.java.net/%7Eptbrunet/JDK-8167213/webrev.01/>
Rather than removing the files needed by Assistive Technology
developers
we have to provide them in JDK. However since there is a .c file
in the
group of files the files were moved from the include directory to a
new
javaaccessbridge directory.
On 10/17/16 2:43 AM, Magnus Ihse Bursie wrote:
On 2016-10-14 17:51, Pete Brunet wrote:
Please review the following.
The .h files and .c file provided to allow Assistive Technology to
interface to the Java Access Bridge API are being removed from
the built
JRE/JDK images. They are not used much and they can be obtained
online
via the OpenJDK web site. The pubs will be updated to mention the
location of the files.
Since there is a .c file in this group of files the directory
structure
has been changed slightly to remove the include directory.
There was one file missing from the group of files needed by
developers
and that was moved from the common to the bridge directory.
The make was updated in response to the above.
Bug:https://bugs.openjdk.java.net/browse/JDK-8167213
<https://bugs.openjdk.java.net/browse/JDK-8167213>
Webrev:http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.00/
<http://cr.openjdk.java.net/%7Eptbrunet/JDK-8167213/webrev.00/>
Build changes looks good to me.
/Magnus
-- Sent from Gmail Mobile
