On Wed, 16 Aug 2023 18:51:03 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert to use static_cast. > > src/hotspot/share/logging/logOutput.cpp line 77: > >> 75: ntags++; >> 76: } >> 77: qsort(tags, ntags, sizeof(*tags), (_sort_Fn)tag_cmp); > > While wondering about, then searching for, _sort_Fn, I found it in > globalDefinitions.hpp and a wrong comment in instanceKlass.cpp > > 1781: // _sort_Fn is defined in growableArray.hpp. > > would you mind fixing that comment or removing it? I removed it, since it seems not helpful. Thanks for reviewing! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15233#discussion_r1296324419
