On Wed, 16 Aug 2023 19:16:28 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:

>> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion 
>> warnings in runtime code.  This is the last one I'm going to do for runtime 
>> for a while.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Remove wrong comment.

src/hotspot/share/utilities/elfFile.hpp line 486:

> 484:     DwarfFile* _dwarf_file;
> 485:     MarkedDwarfFileReader _reader;
> 486:     uint64_t _section_start_address;

This is platform-specific.
Suggestion:

    uintptr_t _section_start_address;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15233#discussion_r1296443060

Reply via email to