[
https://issues.apache.org/jira/browse/CASSANDRA-15543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17054990#comment-17054990
]
Kevin Gallardo edited comment on CASSANDRA-15543 at 3/9/20, 2:07 PM:
---------------------------------------------------------------------
Sounds good.
As a summary,
In any case, I believe passing an immutable copy of the
{{failureReasonByEndpoint}} map to the constructor of
Read/WriteFailureException would reduce the chances for the {{number of
failures}} and the failure messages to be inconsistent.
In addition to that, there's the remaining question of the behavior of
ReadCallback when failures happen (do we fail fast? or do we wait for all
responses to come back/timeout?). Depending on the outcome of that, the test
that is flaky at the moment would need to be adjusted to expect 1 *or* 2
failures in the response.
was (Author: newkek):
Sounds good.
As a summary,
In any case, I believe passing an immutable copy of the
{{failureReasonByEndpoint}} map to the constructor of
Read/WriteFailureException would reduce the chances for the {{number of
failures}} and the failure messages to be inconsistent.
In addition to that, there's the remaining question of the behavior of
ReadCallback when failures happen (do we fail fast? or do we wait for all
responses to come back/timeout?). Depending on the outcome of that the test
that is flaky at the moment would need to be adjusted to expect 1 *or* 2
failures in the response.
> flaky test
> org.apache.cassandra.distributed.test.SimpleReadWriteTest.readWithSchemaDisagreement
> -----------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-15543
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15543
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
> Reporter: David Capwell
> Assignee: Kevin Gallardo
> Priority: Normal
> Fix For: 4.0-alpha
>
>
> This fails infrequently, last seen failure was on java 8
> {code}
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.distributed.test.DistributedReadWritePathTest.readWithSchemaDisagreement(DistributedReadWritePathTest.java:276)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
