[ 
https://issues.apache.org/jira/browse/CASSANDRA-15543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17057091#comment-17057091
 ] 

Kevin Gallardo edited comment on CASSANDRA-15543 at 3/11/20, 3:23 PM:
----------------------------------------------------------------------

Thanks for the reply, Ekaterina, and for confirming the behavior described.

Got some more time to think about this, and it seems the best way to approach 
it, since what I suggest would be a larger behavioral change, would be to 
create a separate ticket for it. 

I think in this ticket I would rather: Fix the discrepancies between the 
failures number and the failure messages with the immutable map copy + fix the 
test that expects 2 failures to only expect 1 to match current behavior. 

Then, in the other ticket we can properly advocate/discuss pros and cons of 
returning cohesive error messages VS fail-fast & incohesive error message.


was (Author: newkek):
Thanks for the reply, Ekaterina. 

Got some more time to think about this, and I think the best way to approach 
it, since what I suggest would be a larger behavioral change, would be to 
create a separate ticket for it.

I think in this ticket I would rather: Fix the discrepancies between the 
failures number and the failure messages with the immutable map copy + fix the 
test that expects 2 failures to only expect 1 to match current behavior. 

Then, in the other ticket we can discuss pros and cons of returning cohesive 
error messages VS fail-fast & incohesive error message.

> flaky test 
> org.apache.cassandra.distributed.test.SimpleReadWriteTest.readWithSchemaDisagreement
> -----------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15543
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15543
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/dtest
>            Reporter: David Capwell
>            Assignee: Kevin Gallardo
>            Priority: Normal
>             Fix For: 4.0-alpha
>
>
> This fails infrequently, last seen failure was on java 8
> {code}
> junit.framework.AssertionFailedError
>       at 
> org.apache.cassandra.distributed.test.DistributedReadWritePathTest.readWithSchemaDisagreement(DistributedReadWritePathTest.java:276)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to