On Tue, 6 Dec 2022 15:41:20 GMT, Doug Simon <dnsi...@openjdk.org> wrote:
>> src/java.base/share/classes/jdk/internal/vm/VMSupport.java line 66:
>>
>>> 64: * only contains String keys and values.
>>> 65: */
>>> 66: private static byte[] serializePropertiesToByteArray(Properties p,
>>> boolean filter) throws IOException {
>>
>> I think we need more context as to why there are non-String system
>> properties in use here.
>
> This parameter exists to allow a caller to pass in a `Properties` object that
> is guaranteed to have only String keys and so does not need the extra
> filtering done in this method. I'll refactor the code to make it clearer.
Hopefully this makes it clearer:
https://github.com/openjdk/jdk/pull/11513/commits/5c610798fe4eaed7efeb2eebcf1e5db47714caee
-------------
PR: https://git.openjdk.org/jdk/pull/11513
