On Thu, 15 Feb 2024 13:07:20 GMT, Claes Redestad <redes...@openjdk.org> wrote:
>> Adding a fast-path for ASCII-only modified UTF-8 strings deserialied via >> Data- and ObjectInputStream >> >> Testing: tier1-3 > > Claes Redestad has updated the pull request incrementally with one additional > commit since the last revision: > > Update src/java.base/share/classes/java/io/DataInputStream.java > > Co-authored-by: Raffaello Giulietti <raffaello.giulie...@oracle.com> Looks fine. test/micro/org/openjdk/bench/java/io/DataInputStreamTest.java line 2: > 1: /* > 2: * Copyright (c) 2020, 2024, Red Hat Inc. All rights reserved. Suggestion: * Copyright (c) 2020, Red Hat Inc. All rights reserved. * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved. AFAIU, we don't update 3rd party copyright notices. test/micro/org/openjdk/bench/java/io/ObjectInputStreamTest.java line 2: > 1: /* > 2: * Copyright (c) 2020, 2024, Red Hat Inc. All rights reserved. Probably the result of a copy&paste... Suggestion: * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved. ------------- PR Review: https://git.openjdk.org/jdk/pull/17734#pullrequestreview-1885257935 PR Review Comment: https://git.openjdk.org/jdk/pull/17734#discussion_r1492524358 PR Review Comment: https://git.openjdk.org/jdk/pull/17734#discussion_r1492525025
