On Mon, 18 Mar 2024 14:53:44 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
> Please review this simple bugfix to properly construct links to preview JEPs. > > The most straightforward fix I could think of was to pass `String` rather > than `int` (`Integer`) to a method, which eventually calls > `java.text.MessageFormat.format(String, Object...)`. > > For the test, I decided to be ~lazy~ practical and piggyback on the existing > infrastructure. The alternatives were: > > 1. slap `noreg-hard` on the JBS bug and skip testing > 2. create a sophisticated test that dynamically adds a constant into the > `PreviewFeature.Feature` enum, annotates some class with `PreviewFeature` > with that constant, and finally documents that class with `PreviewFeature` > patched into `java.base` > > While (1) is insufficient, (2) seems overkill in this case. Hm... it's surprising to see that the Skara bots consider that src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java belongs to core-libs, but not to compiler. Let me manually add it. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18350#issuecomment-2004168270
